fix(dag): report corrupted DAGs in compact/json output formats#228
Open
davidweb3-ctrl wants to merge 4 commits intoCortexLM:mainfrom
Open
fix(dag): report corrupted DAGs in compact/json output formats#228davidweb3-ctrl wants to merge 4 commits intoCortexLM:mainfrom
davidweb3-ctrl wants to merge 4 commits intoCortexLM:mainfrom
Conversation
When bumping from a prerelease version (e.g., 1.0.0-beta.1), the script now correctly transitions to the stable version instead of incrementing and skipping the stable release. Changes: - Detect if current version is a prerelease (contains '-') - For prerelease versions: patch/minor/major bumps now return the base stable version (e.g., 1.0.0-beta.1 -> 1.0.0) - For stable versions: behavior unchanged (normal increment) Fixes: PlatformNetwork/bounty-challenge#47839
The script was looking for cortex-cli/Cargo.toml at the repository root, but the crate is actually located at src/cortex-cli/Cargo.toml per the workspace configuration. This caused the version validation check to be silently skipped, as the file existence check failed. Changes: - Updated CORTEX_CLI_CARGO path from cortex-cli/Cargo.toml to src/cortex-cli/Cargo.toml Fixes: PlatformNetwork/bounty-challenge#47866
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent error handling where corrupted DAGs were silently hidden in --format compact and --format json, while --format text correctly showed error indicators.
Bug Description
When a DAG state file is corrupted (invalid JSON):
Root Cause
The compact and json format handlers only handled the Ok(dag) case and silently skipped errors:
Changes
Fixes: PlatformNetwork/bounty-challenge#47965