Skip to content

[skip ci] fix: batch fixes for issues #2974, 2978, 2979, 2980, 2982, 2984, 2986, 2987, 2989, 2991 #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echobt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[skip ci] fix: batch fixes for issues #2974, 2978, 2979, 2980, 2982, 2984, 2986, 2987, 2989, 2991 #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion cortex-cli/src/debug_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,21 @@ async fn run_config(args: ConfigArgs) -> Result<()> {
// Show hints about available options
println!();
println!("Tip: Use --json for machine-readable output, --env for environment variables.");

// Issue #2984: Show hint about provider-specific configuration sections
println!();
println!("Provider Configuration (Issue #2984):");
println!("{}", "-".repeat(40));
println!(" Configure provider-specific settings in config.toml:");
println!();
println!(" [providers.openai]");
println!(" api_key_env = \"OPENAI_API_KEY\"");
println!(" base_url = \"https://api.openai.com/v1\"");
println!();
println!(" [providers.anthropic]");
println!(" api_key_env = \"ANTHROPIC_API_KEY\"");
println!();
println!(" See: https://docs.cortex.foundation/configuration");
}

// Handle --diff flag: compare local and global configs
Expand Down Expand Up @@ -2057,7 +2072,14 @@ async fn run_paths(args: PathsArgs) -> Result<()> {
];

for (name, info) in paths {
let status = if info.exists { "exists" } else { "missing" };
// Issue #2979: Show appropriate status for logs directory
let status = if info.exists {
"exists"
} else if name == "Logs" {
"optional" // Logs dir is created on demand when logging is enabled
} else {
"missing"
};
let path_display = info.path.display().to_string();
let path_truncated = if path_display.len() > 38 {
format!("...{}", &path_display[path_display.len() - 35..])
Expand All @@ -2071,6 +2093,13 @@ async fn run_paths(args: PathsArgs) -> Result<()> {
}
}
}

// Issue #2979: Add note about logs directory
if !output.logs_dir.exists {
println!();
println!("Note: Logs directory is created on demand when using --log-file option.");
println!(" Use 'cortex exec --log-file <path>' to enable file logging.");
}
}

Ok(())
Expand Down
Loading