[skip ci] fix: batch fixes for issues #1937, #1938, #1941, #1942, #1945, #1946, #1950, #1952, #1953, #1954#386
Open
[skip ci] fix: batch fixes for issues #1937, #1938, #1941, #1942, #1945, #1946, #1950, #1952, #1953, #1954#386
Conversation
… #1950, #1952, #1953, #1954 [skip ci] Fixes: - #1937: Block debug file access to sensitive system files - #1938: Block debug file access to /proc and /sys filesystems - #1941: Cap scrape --timeout at 3600 seconds (1 hour) - #1942: Block dangerous shell patterns in mcp add commands - #1945: Consistent error messages for unsupported URL schemes in scrape - #1946: Output JSON error when agent show fails with --json flag - #1950: Output JSON error when debug file missing path with --json flag - #1952: Detect and reject compressed responses in scrape command - #1953: Detect and reject binary content in scrape command - #1954: Add --model flag to serve command Additional fixes for pre-existing build issues: - Add trust_proxy field to RateLimitConfig - Fix duplicate output field in run_cmd.rs - Make install_panic_hook public - Remove cookie_store call (feature not enabled)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch fix for multiple bounty issues.
Issues Fixed
Changes
debug_cmd.rs: Addvalidate_path_security()function to block access to sensitive paths and /proc/sys filesystemsscrape_cmd.rs: Add URL scheme validation, timeout cap, content-type and binary detectionmcp_cmd.rs: Add dangerous shell pattern detection invalidate_command_args()agent_cmd.rs: Return JSON error object when agent not found with --json flagmain.rs: Add --model flag to serve command