Skip to content

Conversation

@yuvalkarif
Copy link

@yuvalkarif yuvalkarif commented Nov 10, 2024

fix: #2
I've completed the first version of the update feature. If this approach looks good, I'd be happy to add an interactive mode next.

Key points and questions:

  1. Added settings.json file since it's recommended by @antfu/eslint-config and needed for proper editor setup

  2. Currently using the YAML parser which is well-tested, but we could switch to parsing the pnpm.workspace file manually since its format is straightforward. What do you prefer?

  3. Should we add automatic code formatting (using Prettier/ESLint) when writing files?

  4. Since pnpm list doesn't show version requirement symbols (like ^ or >=), I defaulted to using ^. We can either:

    • Parse this from package.json files
    • Let users specify their preference in interactive mode
  5. Updated the console output colors, using taze as inspiration for the color scheme

  6. Note: Originally planned to support peerDependencies and optionalDependencies, but removed this for now since pnpm list only shows dev dependency status.

@yuvalkarif yuvalkarif marked this pull request as draft November 10, 2024 14:35
@yuvalkarif yuvalkarif marked this pull request as ready for review November 10, 2024 15:32
@yuvalkarif yuvalkarif changed the title feat(update): #2 update mode feat(update): update mode Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add --write or --resolve Option

1 participant