-
Notifications
You must be signed in to change notification settings - Fork 966
fix: strip MCP namespace prefix from tool names in batch_execute #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| """Tests for strip_mcp_prefix in batch_execute.""" | ||
|
|
||
| import pytest | ||
| from services.tools.batch_execute import strip_mcp_prefix | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "input_name,expected", | ||
| [ | ||
| # Plain names pass through unchanged | ||
| ("manage_gameobject", "manage_gameobject"), | ||
| ("batch_execute", "batch_execute"), | ||
| # Colon format (e.g. Claude Desktop) | ||
| ("UnityMCP:manage_gameobject", "manage_gameobject"), | ||
| ("unityMCP:batch_execute", "batch_execute"), | ||
| # Double-underscore format (e.g. Claude Code) | ||
| ("mcp__UnityMCP__manage_gameobject", "manage_gameobject"), | ||
| ("mcp__UnityMCP__batch_execute", "batch_execute"), | ||
| ("mcp__UnityMCP__manage_scene", "manage_scene"), | ||
| # Tool name itself contains underscores — should be preserved | ||
| ("mcp__UnityMCP__manage_scriptable_object", "manage_scriptable_object"), | ||
| # Edge cases: trailing separators pass through unchanged (match C# behavior) | ||
| (":", ":"), | ||
| ("Server:", "Server:"), | ||
| ("mcp__Server__", "mcp__Server__"), | ||
| # Empty string passes through | ||
| ("", ""), | ||
| # Multiple colons: last segment used | ||
| ("a:b:manage_gameobject", "manage_gameobject"), | ||
| ], | ||
| ) | ||
| def test_strip_mcp_prefix(input_name: str, expected: str): | ||
| assert strip_mcp_prefix(input_name) == expected |
52 changes: 52 additions & 0 deletions
52
TestProjects/UnityMCPTests/Assets/Tests/EditMode/Tools/BatchExecuteStripPrefixTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| using NUnit.Framework; | ||
| using MCPForUnity.Editor.Tools; | ||
|
|
||
| namespace MCPForUnityTests.Editor.Tools | ||
| { | ||
| public class BatchExecuteStripPrefixTests | ||
| { | ||
| [Test] | ||
| public void StripMcpPrefix_PlainName_ReturnsUnchanged() | ||
| { | ||
| Assert.AreEqual("manage_gameobject", BatchExecute.StripMcpPrefix("manage_gameobject")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void StripMcpPrefix_ColonFormat_StripsPrefix() | ||
| { | ||
| Assert.AreEqual("manage_gameobject", BatchExecute.StripMcpPrefix("UnityMCP:manage_gameobject")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void StripMcpPrefix_DoubleUnderscoreFormat_StripsPrefix() | ||
| { | ||
| Assert.AreEqual("manage_gameobject", BatchExecute.StripMcpPrefix("mcp__UnityMCP__manage_gameobject")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void StripMcpPrefix_DoubleUnderscore_ToolWithUnderscores_PreservesToolName() | ||
| { | ||
| Assert.AreEqual("batch_execute", BatchExecute.StripMcpPrefix("mcp__UnityMCP__batch_execute")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void StripMcpPrefix_NullOrEmpty_ReturnsSame() | ||
| { | ||
| Assert.IsNull(BatchExecute.StripMcpPrefix(null)); | ||
| Assert.AreEqual("", BatchExecute.StripMcpPrefix("")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void StripMcpPrefix_ColonOnly_PassesThrough() | ||
| { | ||
| // Edge case: ":" alone — no valid suffix, passes through (will fail at CommandRegistry) | ||
| Assert.AreEqual(":", BatchExecute.StripMcpPrefix(":")); | ||
| } | ||
|
|
||
| [Test] | ||
| public void StripMcpPrefix_MultipleColons_UsesLast() | ||
| { | ||
| Assert.AreEqual("manage_gameobject", BatchExecute.StripMcpPrefix("a:b:manage_gameobject")); | ||
| } | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
TestProjects/UnityMCPTests/Assets/Tests/EditMode/Tools/BatchExecuteStripPrefixTests.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.