Harden CI: SHA-pin all actions, add persist-credentials: false#83
Merged
Conversation
- SHA-pin actions/checkout, actions/setup-node, pnpm/action-setup, and slackapi/slack-github-action to immutable commit SHAs - Add persist-credentials: false to all checkout steps to limit token exposure in a public repo - Add top-level permissions: contents: read to enforce least privilege
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkout,actions/setup-node,pnpm/action-setup,slackapi/slack-github-action) to immutablecommit SHAs with version comments
persist-credentials: falseto allactions/checkoutsteps toprevent token leakage in a public repo
permissions: contents: readto enforce least-privilegeon the workflow's GITHUB_TOKEN
Why
Public repos are vulnerable to supply-chain attacks via tag-mutable
action references. SHA-pinning ensures the exact code that was audited
is what runs. Restricting token permissions and persistence limits blast
radius if a dependency is compromised.
Test plan