Skip to content

Conversation

@jabbate19
Copy link
Collaborator

No description provided.

@jabbate19
Copy link
Collaborator Author

A file is needed to act as the "Secret Key", but that will be added manually to the container

@jabbate19 jabbate19 requested a review from WillNilges March 15, 2022 02:06
Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok. I'll approve it when I test it.

Comment on lines +72 to +81
// TODO: To avoid memory issues, move this client generation outside
// of this example, and cache it (recommended) or call client.close()
// before exiting this method.
ctx := context.Background()
client, err := recaptcha.NewClient(ctx)
if err != nil {
fmt.Printf("Error creating reCAPTCHA client:%s\n", err)
return false
}
defer client.Close()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should follow this TODO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we're gonna keep using the client, so we might as well keep it around, y'know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants