wheel_architecture adjustments for 2023 #102
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As they are compiled with `-march=x86-64-v3` they are highly unlikely to work on older arches, since even simple code often uses BMI2 instructions. So we cannot typically share them with older StdEnv as they'll break.
So we know they can't be shared with future StdEnv, unlike "gentoo2023 generic" wheels.
Member
|
Hum, it's not because these instructions are present that they are used. By these tests, we probably could never have numpy (or any wheel that does runtime detection) that is considered anything less than the most complete instruction set |
Contributor
|
These test are to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gentoo2023as they can't be shared as purely generic with older StdEnv: they are highly likely to contain illegal instructions for CPUs without AVX2 or BMI2.