Skip to content

Generalize ceph.pp to allow multiple cephfs mounting #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmd-ntrf merged 12 commits into from
May 14, 2024
Merged

Generalize ceph.pp to allow multiple cephfs mounting #313

cmd-ntrf merged 12 commits into from
May 14, 2024

Conversation

@cmd-ntrf
Copy link
Member

@cmd-ntrf cmd-ntrf commented Jan 25, 2024

No description provided.

@cmd-ntrf cmd-ntrf added the enhancement New feature or request label Jan 25, 2024
@cmd-ntrf cmd-ntrf requested a review from mboisson January 25, 2024 16:59
@cmd-ntrf cmd-ntrf self-assigned this Jan 25, 2024
@mboisson
Copy link
Member

mboisson commented Jan 25, 2024

Looks good to me. Works as intended to mount 4 different CephFS shares.

@mboisson
Copy link
Member

mboisson commented Jan 25, 2024

I opened PR #314 to allow mount binds to be of files in addition to directories

@mboisson mboisson mentioned this pull request Jan 25, 2024
Closed
@cmd-ntrf
Merge pull request #314 from mboisson/patch-1
0f04003 
Allow mount binds to be files instead of directories
mboisson
mboisson approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@mboisson mboisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cmd-ntrf
Replace Tuple by Struct for BindMount
da95657 
Also rename variable
@cmd-ntrf
Fix mon_host
f43b38a 
Mon host are ip:port and there is no available pattern in Puppet to
validate that.
@cmd-ntrf cmd-ntrf linked an issue Jan 26, 2024 that may be closed by this pull request
Supporting multiple CephFS mounts #305
Closed
poquirion added a commit to c3g/puppet-magic_castle that referenced this pull request Mar 19, 2024
@poquirion
cherry pick from ComputeCanada#313
cad158d
@poquirion
Copy link
Member

poquirion commented Mar 21, 2024

I have cherry picked the changes here and used cephFS for /home and got this when login in:

Could not chdir to home directory /home/poq: No such file or directory

I guess the cephfs should be mounted before the user are created. I am not shure how that would be done contitionally. I guess there is some way of handly that when using nfs. That also means that the cephFS needs to be mounted on the system where FreeIPA is running

@mboisson
Copy link
Member

mboisson commented Mar 21, 2024

I have cherry picked the changes here and used cephFS for /home and got this when login in:

Could not chdir to home directory /home/poq: No such file or directory

I guess the cephfs should be mounted before the user are created. I am not shure how that would be done contitionally. I guess there is some way of handly that when using nfs. That also means that the cephFS needs to be mounted on the system where FreeIPA is running

You may want this one for this use case:
#317

@poquirion
Copy link
Member

poquirion commented Mar 21, 2024 •
edited
Loading

One cherry at a time, untill all is upstream. Thanks @mboisson

[poq@login1 ~]$ pwd
/home/poq

poquirion added a commit to c3g/puppet-magic_castle that referenced this pull request Mar 28, 2024
@poquirion
cherry pick from ComputeCanada#313
b7bf6e0
poquirion added a commit to c3g/puppet-magic_castle that referenced this pull request Apr 15, 2024
@poquirion
cherry pick from ComputeCanada#313
d8ab3bc
@cmd-ntrf cmd-ntrf merged commit b2c2819 into main May 14, 2024
@cmd-ntrf cmd-ntrf deleted the generalize_ceph branch September 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mboisson mboisson mboisson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmd-ntrf cmd-ntrf

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting multiple CephFS mounts

4 participants

@cmd-ntrf @mboisson @poquirion