Skip to content

Add EMPIAR 11618 experimental recon#1361

Merged
garrettwrong merged 4 commits intodevelopfrom
exp11618
Feb 10, 2026
Merged

Add EMPIAR 11618 experimental recon#1361
garrettwrong merged 4 commits intodevelopfrom
exp11618

Conversation

@garrettwrong
Copy link
Collaborator

Adds gallery example for EMPIAR 11618 recon.

The data for this is clean enough that we can use the randomized class selection to avoid the expensive entire class average set generation. Raw data to recon volume with 1 A100 GPU is taking about 2 hours and about 20A at 129 pixels.

I did try using various preprocessing techniques. While most were slightly faster preprocessing, they all had decreased recon accuracy in my (limited) testing runs.

Most of my runs were at 50 neighbors per class average. I'm currently testing with 100 as written here and will decide based on the FSC and visuals what to initially recommend before proofreading and opening up for review.

@garrettwrong garrettwrong self-assigned this Feb 2, 2026
@garrettwrong garrettwrong added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 2, 2026
@garrettwrong
Copy link
Collaborator Author

Using the non-legacy preprocessing seems to give up about 0.5A in this configuration so I went with that. Probably in the future it can improve.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (50d79b3) to head (34006d1).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1361   +/-   ##
========================================
  Coverage    90.87%   90.87%           
========================================
  Files          135      135           
  Lines        14678    14678           
========================================
  Hits         13339    13339           
  Misses        1339     1339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@garrettwrong garrettwrong marked this pull request as ready for review February 9, 2026 16:53
@garrettwrong garrettwrong requested a review from janden as a code owner February 9, 2026 16:53
@garrettwrong
Copy link
Collaborator Author

Github having some issues, will return to restart these later. This code diff doesn't actually run in anything other than the doc build so the CI should go through normally ....

@garrettwrong
Copy link
Collaborator Author

Github having some issues, will return to restart these later. This code diff doesn't actually run in anything other than the doc build so the CI should go through normally ....

GH appears healthier today. Restarted.

@garrettwrong
Copy link
Collaborator Author

Going to merge this in just to keep the PR area tidy. We can tweak it before the next release if any concerns.

@garrettwrong garrettwrong merged commit 9de8047 into develop Feb 10, 2026
51 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants