Skip to content

Patch covar direct solver#1360

Merged
garrettwrong merged 2 commits intodevelopfrom
fixcovarestsolve
Feb 4, 2026
Merged

Patch covar direct solver#1360
garrettwrong merged 2 commits intodevelopfrom
fixcovarestsolve

Conversation

@garrettwrong
Copy link
Collaborator

Patches incorrect line in covar est direct solver branch.

Adds invert and condition method for DiagMatrix class along with basic unit test. Fixes a small typo.

@garrettwrong garrettwrong self-assigned this Jan 30, 2026
@garrettwrong garrettwrong added bug Something isn't working enhancement New feature or request cleanup labels Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (7d2d875) to head (27399ee).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1360   +/-   ##
========================================
  Coverage    90.87%   90.87%           
========================================
  Files          135      135           
  Lines        14672    14678    +6     
========================================
+ Hits         13333    13339    +6     
  Misses        1339     1339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@garrettwrong garrettwrong requested a review from j-c-c January 30, 2026 18:08
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong garrettwrong marked this pull request as ready for review January 30, 2026 18:41
@garrettwrong garrettwrong requested a review from janden as a code owner January 30, 2026 18:41
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettwrong garrettwrong merged commit f45cf8e into develop Feb 4, 2026
44 checks passed
@garrettwrong garrettwrong deleted the fixcovarestsolve branch February 4, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants