rename module #481
Draft
rename module #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been depending on a very old edition of x/transfermiddleware in packet forward middleware.
In order to resolve this, we need to rename the module from github.com/notional-labs/composable/v6 to github.com/ComposableFi/composable-cosmos/v6 and then reference a v6.6.0, but for now we can just use this commit.
Then, we need to update packet forward middleware to refer to this commit, and push that to our fork.
This also involves refactoring simapp in packetforwardmiddleware.
From there, we make another update to this branch to refer to that, and we can continue to debug knowing that we're for sure using the correct code.
The ongoing simapp refactor is here:
https://github.com/faddat/ibc-apps/tree/faddat/composable-ibc-apps
We won't want to merge this PR until the changes to ibc-apps are completed.