Skip to content

CMP-3743: Remove unused Bearer token auth from metrics ServiceMonitor#1072

Merged
yuumasato merged 1 commit intomasterfrom
metrics_token
Mar 31, 2026
Merged

CMP-3743: Remove unused Bearer token auth from metrics ServiceMonitor#1072
yuumasato merged 1 commit intomasterfrom
metrics_token

Conversation

@Vincent056
Copy link
Copy Markdown

The metrics endpoint only uses TLS for security and does not validate Bearer tokens. Remove the dead code that configured token authorization and created the associated secret.

The metrics endpoint only uses TLS for security and does not validate
Bearer tokens. Remove the dead code that configured token authorization
and created the associated secret.
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@Vincent056: This pull request references CMP-3743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The metrics endpoint only uses TLS for security and does not validate Bearer tokens. Remove the dead code that configured token authorization and created the associated secret.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions
Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1072-4aa68ebdc8598ec3d2128863d8703659d6d32608

@Vincent056
Copy link
Copy Markdown
Author

/retest
failures unrelated due to infra

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 2, 2026

@Vincent056: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 4aa68eb link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato yuumasato added this to the 1.9.0 milestone Mar 30, 2026
@yuumasato yuumasato self-assigned this Mar 31, 2026
Copy link
Copy Markdown
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Vincent056,yuumasato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato yuumasato merged commit 330dcbe into master Mar 31, 2026
20 of 23 checks passed
@yuumasato yuumasato deleted the metrics_token branch March 31, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants