Use basic shadow sampling if pixelation effects are in use#281
Open
chocolatemintychip wants to merge 3 commits intoComplementaryDevelopment:mainfrom
Open
Use basic shadow sampling if pixelation effects are in use#281chocolatemintychip wants to merge 3 commits intoComplementaryDevelopment:mainfrom
chocolatemintychip wants to merge 3 commits intoComplementaryDevelopment:mainfrom
Conversation
Member
|
Makes sense. I'll try it out :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using jittered sampling with pixelated shadows causes dot crawl artifacts, which are especially noticeable on lower shadow qualities. This PR forces basic filtering if pixelated shadows are enabled. As far as I can tell this doesn't break anything. Not really sure what performance implications of this are, but I feel like the impact is probably next to nothing.
TAA turned off for clarity, the artifacting is still there with it on.