Closes #451 - Add pragma restore directive for the CS0108 warning#773
Draft
GabrieleMessina wants to merge 3 commits intoCommunityToolkit:mainfrom
Draft
Conversation
…d handle the new keyword in the property declaration if the hidesInheritedProperty argument is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451
I've added a pragma restore directive for the CS0108 warning into the ObservableObject class source generator.
I haven't updated the tests to support the newly generated code yet. I want to be sure this can be a good solution before proceeding to that seeing that updating the test is a lot of work.
@Sergio0694 Can you confirm I can proceed?
PR Checklist
Other information
I've not found a way of testing the newly generated code on an actual class that inherits from
ObservableObject.When I try to add this kind of class nothing goes generated under the hood. There is a way of testing this like I'm working with the final nuget package?