Adding Uno support (updated)#38
Adding Uno support (updated)#38nickrandolph wants to merge 23 commits intoCommunityToolkit:masterfrom
Conversation
Fixing up droid
|
Hey @nickrandolph, sorry for the delay. I didn't see the GitHub notification, not sure if it was because it was a new PR vs. updating the old one. It seems you hadn't Also, I noticed you pinned the SDK Extras to an older version, is there a specific reason you weren't using latest? And with the Icon Glyphs removed nothing shows for even the UWP sample, right? Does the Uno NavigationViewItem not support the Icons? Also adding @kazo0 if he has any suggestions as a member of the Uno team and to help us coordinate these two PRs better. Thanks! |
|
Hey @nickrandolph - if you have time to get back to this please rebase the PR off of main, and ensure that you have no files being deleted/created, but only moved, if any. If you rebase in theory that should at least in part get fixed already, since all the backend viewmodels will have been moved to a separate project already 🙂 |
|
@nickrandolph was this still something you were interested in contributing this? I know a lot has changed between the prior split in this repo to have the separate .NET Standard project to facilitate code-share and then Uno itself with the TreeView in NavigationView support. Wondering if it makes sense to revive this PR or start a new-one from the latest |
|
I'm guessing it probably makes sense to take a new branch of current main and add the Uno sample. I'll see whether I have capacity in the coming week |
No description provided.