Skip to content

More markdowntextblock improvements #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
niels9001 merged 28 commits into from
Jan 16, 2026
Merged

More markdowntextblock improvements #771

niels9001 merged 28 commits into from
Jan 16, 2026

Conversation

@niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Jan 9, 2026 •
edited
Loading

  • Updating a few default styles
  • Large images would be stretched beyond their parent container width. This PR fixes that and images will now scale accordingly when the image is larger than the actual window / parent size.

@niels9001 niels9001 requested a review from Copilot January 9, 2026 14:59
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the MarkdownTextBlock image handling by replacing fixed Width/Height sizing with a MaxWidth/MaxHeight constraint-based approach, preventing images from being stretched beyond their parent container. It also includes XAML formatting improvements for the theme options pane and updates to sample documentation.

  • Changed image sizing from fixed dimensions to flexible MaxWidth/MaxHeight constraints to prevent stretching
  • Simplified constraint application logic by directly using MaxWidth/MaxHeight instead of complex scaling calculations
  • Reformatted XAML file with consistent indentation and attribute placement

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
MyImage.cs Refactored image sizing logic to use MaxWidth/MaxHeight constraints instead of fixed dimensions, allowing images to scale properly within their containers
ThemeOptionsPane.xaml Applied consistent code formatting with proper indentation and line breaks
MarkdownTextBlockCustomThemeSample.xaml.cs Added documentation about image corner radius feature and included additional sample image

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Arlodotexe and others added 2 commits January 9, 2026 19:17
@Arlodotexe
Apply suggestion from @Copilot
0811436 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Arlodotexe
Add ImageProviderConstraintTest to verify theme constraint behavior
4cc9798 
- Tests that theme constraints should not enlarge images smaller than the constraint
- Tests that precedent dimensions from markdown syntax should be respected
- Tests that theme constraints properly limit larger images
- Reveals current bugs where constraints are always applied regardless of context
Arlodotexe
Arlodotexe requested changes Jan 10, 2026
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surfaced a few regressions:

  • This should be fixed in this PR before closing. Failing tests have been pushed to demonstrate the issue.
  • The missing image corner radius bit should be handled in a new PR.

The remaining review comments from Copilot are either trivial and already merged or false positives.

Copilot AI reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Arlodotexe
Arlodotexe reviewed Jan 12, 2026
View reviewed changes
@niels9001 niels9001 mentioned this pull request Jan 13, 2026
Merged
11 tasks
@Arlodotexe Arlodotexe mentioned this pull request Jan 13, 2026
Open
20 tasks
@niels9001 niels9001 requested a review from Arlodotexe January 13, 2026 23:43
lei9444 added a commit to microsoft/PowerToys that referenced this pull request Jan 15, 2026
@niels9001 @lei9444
"What's new" improvements (#44638)
1dddf9f 
<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request

TO DO: Upgrade to the latest version of MarkdownTextBlock:
CommunityToolkit/Labs-Windows#771

This PR introduces the following changes:
**Removed the custom titlebars on the OOBE Window, and replaced it with
the inbox WinUI `TitleBar` control.**

**New "What's new" experience following the VS Code release notes
experience**
- Created a new SCOOBE Windows that is a standalone window to better
visualize release notes.
- Adding a nav menu on the left to easily switch between release notes,
instead of a long page.
- Point releases are combined with the latest main release.. e.g. 0.96.1
is rendered above 0.96.0.
- The 'hero image' on main release notes will automatically be rendered
at the top of the page.
- Improved markdown styling for better readability.
- Pull requests links can now be clicked.
- Upgraded `CommunityToolkit.Labs.MarkdownTextblock` to the latest
version as it includes much needed bugfixes.

<img width="1234" height="819" alt="image"
src="https://github.com/user-attachments/assets/447b3136-306b-4f24-bc7a-c022a99e8e51"
/>

Note: the blurry image shown above will be replaced in new releases by
an image that fits the right dimensions.

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist

- [ ] Closes: #xxx
<!-- - [ ] Closes: #yyy (add separate lines for additional resolved
issues) -->
- [ ] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [ ] **Tests:** Added/updated and all pass
- [ ] **Localization:** All end-user-facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json)
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs)
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml)
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml)
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys)
and link it here: #xxx

<!-- Provide a more detailed description of the PR, other things fixed,
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

---------

Co-authored-by: Leilei Zhang <leilzh@microsoft.com>
@niels9001 niels9001 enabled auto-merge January 16, 2026 13:27
@niels9001 niels9001 merged commit 389b9ca into main Jan 16, 2026
24 checks passed
@Arlodotexe Arlodotexe deleted the niels9001/mdtb-improvements branch January 16, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niels9001 @Arlodotexe