fix: resolve workflow validation error and test script path#191
Merged
accesswatch merged 3 commits intomainfrom May 8, 2026
Merged
fix: resolve workflow validation error and test script path#191accesswatch merged 3 commits intomainfrom
accesswatch merged 3 commits intomainfrom
Conversation
added 3 commits
May 8, 2026 11:23
- Restructure docs and classroom content - Add .gitattributes to enforce LF line endings across all text files - Remove deprecated podcast bundles, scripts, and transcripts - Remove old HTML file mappings replaced by updated structure - Update admin, docs, html, and learning-room content
- Remove secrets.* reference from step-level if condition in registration.yml (GitHub Actions does not support secrets in step if expressions) - Update podcast scripts test to walk subdirectories recursively (scripts were reorganised from flat files into challenges/chapters/appendices)
Contributor
Peer Review AssignedHi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review. For @taylorarndt:This is a great opportunity to practice code review skills! Here's what to look for: Content Quality:
Accessibility:
Documentation:
Review Guidelines:
Resources: Pairing by Learning Room Grouping Engine |
There was a problem hiding this comment.
Pull request overview
This PR addresses two regressions from a prior merge: a GitHub Actions workflow validation failure in the registration workflow and a failing automation test after podcast script files were reorganized into subdirectories.
Changes:
- Updates the registration workflow step condition to avoid unsupported
secrets.*usage in step-levelifexpressions. - Fixes the “generated podcast scripts avoid stale boilerplate” automation test by recursively discovering
.txtscript files underpodcasts/scripts/.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/registration.yml | Removes secrets.* from a step-level if to restore workflow validation. |
| .github/scripts/tests/challenge-doc-consistency.test.js | Recursively collects .txt podcast script files so the test works with nested directories. |
Comment on lines
+150
to
153
| vars.CLASSROOM_ORG != '' | ||
| uses: actions/github-script@v7 | ||
| env: | ||
| CLASSROOM_ORG: ${{ vars.CLASSROOM_ORG }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues from the previous merge\n\n### 1.
registration.ymlworkflow validation failure\n\nGitHub Actions does not supportsecrets.*references in step-levelifexpressions. The step was gated onsecrets.CLASSROOM_ORG_ADMIN_TOKEN != '', which caused the workflow file to fail Actions validation on every push.\n\nFix: Removed the secrets check from theifcondition. The step is now gated solely onvars.CLASSROOM_ORG != ''. If the secret is unset,github-tokenwill fall back to the default token (no org invite will be sent, which is the safe default).\n\n### 2. Automation Tests failure -- podcast scripts not found\n\nThegenerated podcast scripts avoid stale boilerplatetest usedfs.readdirSync(non-recursive) onpodcasts/scripts, expecting.txtfiles in the root. The scripts were reorganised into subdirectories (challenges/,chapters/,appendices/) in the previous commit.\n\nFix: ReplacedreaddirSyncwith a recursivecollectTxtFiles()helper that walks all subdirectories.