Add addConstituent for group admin resource API #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligangty
reviewed
Aug 26, 2025
src/main/java/org/commonjava/indy/service/repository/data/cassandra/CassandraStoreQuery.java
Show resolved
Hide resolved
sswguo
reviewed
Aug 26, 2025
src/main/java/org/commonjava/indy/service/repository/data/AbstractStoreDataManager.java
Outdated
Show resolved
Hide resolved
yma955
commented
Aug 28, 2025
| Group group = (Group) store; | ||
| putValueIntoExtra( CassandraStoreUtil.CONSTITUENTS, group.getConstituents(), extras ); | ||
| // Use admin resource addConstituentToGroup API to add the member of group instead | ||
| // putValueIntoExtra( CassandraStoreUtil.CONSTITUENTS, group.getConstituents(), extras ); |
Member
Author
There was a problem hiding this comment.
@sswguo Do you think we need to annotate this line? I removed this since it may cause the CONSTITUENTS override race condition, and introduce dirty data, we have new API could cover the members data append instead. But after removing the group update call from Indy Koji: Commonjava/indy@8ad742a, I think this part may not be involved either anymore, there's no need to make any further change on this, WDYT?
Member
There was a problem hiding this comment.
yeah, this should be kept as before. We just introduce that new endpoint for adding remote repo, and which does not impact the other parts, like the one creating/updating the group, they still need this to update the members.
Member
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.