Fix range IndexError when processing the radas signing json#389
Fix range IndexError when processing the radas signing json#389yma955 wants to merge 2 commits intoCommonjava:mainfrom
Conversation
|
Coveralls is down for maintenance, check will pass after its back. |
charon/pkgs/radas_sign.py
Outdated
| logger.warning("Invalid entry: %s, skip signature file generation.", file_path) | ||
| return | ||
| # remove the root path maven-repository, valid file_path: maven-repository/... | ||
| filename = parts[1] |
There was a problem hiding this comment.
I think we should refine this logic. We can not predict that the radas signing path is starting with a $root(default is "maven-repository"), instead we should do some checking as below:
- use $root from the "handle_maven_upload" in maven.py instead of the fixed "maven-repository" here
- we should also check if the path is starting with this $root, and then decide how to do this path handling.
There was a problem hiding this comment.
@ligangty here is just a statement, I didn't predict radas result with fixed prefix "maven-repository" in code, any other root name would also be ok, and in following I use top_level to adapt the root cases.
To extend, we may just think about the result case of file path which not starts with(or contains) root, maybe we could join the top_level with the file path directly without any root name removal, WDYT?
There was a problem hiding this comment.
That sounds reasonable. If the $root does not exist in the result path, we should directly handle it. But if it exists, it should be as the prefix and we should remove it.
2 participants
No description provided.