Skip to content

Conversation

@Xyc2016
Copy link
Contributor

@Xyc2016 Xyc2016 commented Jan 8, 2026

Fixes issue with installing older ComfyUI versions.

The GitHub Releases API defaults to 30 releases per page, so older versions may not be visible when fetching releases. While it is possible to fetch additional pages, this PR simplifies the workflow by directly checking out the requested git tag, allowing installation of any stable release version without relying on release pagination.

References: #340

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/install.py 0.00% 7 Missing ⚠️
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   52.23%   51.93%   -0.30%     
==========================================
  Files          32       32              
  Lines        3519     3489      -30     
==========================================
- Hits         1838     1812      -26     
+ Misses       1681     1677       -4     
Files with missing lines Coverage Δ
comfy_cli/command/install.py 55.11% <0.00%> (-2.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the fetch_github_releases , parse_releases and select_version functions if they are not used anymore?

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 9, 2026
@Xyc2016
Copy link
Contributor Author

Xyc2016 commented Jan 9, 2026

@bigcat88
I’ve removed fetch_github_releases, parse_releases, and select_version along with their associated tests since they’re no longer used after switching to tag-based checkout.

@bigcat88 bigcat88 merged commit c3df6cd into Comfy-Org:main Jan 9, 2026
11 checks passed
@bigcat88
Copy link
Contributor

bigcat88 commented Jan 9, 2026

Thanks for this PR!

@Xyc2016 Xyc2016 deleted the install-by-tag branch January 10, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants