Conversation
nstepien
commented
Mar 18, 2026
| let consoleErrorOrConsoleWarnWereCalled = false; | ||
|
|
||
| beforeAll(() => { | ||
| // replace instead of mutating `console` to avoid infinite loops |
Collaborator
Author
There was a problem hiding this comment.
Probably hasn't been an issue for a while.
Maybe it was an issue with an older implementation of failOnConsole, or with JSDOM?
| ) | ||
| .toBe(false); | ||
| // avoid failing test runs twice | ||
| if (task.result!.state !== 'fail' || signal.aborted) { |
Collaborator
Author
There was a problem hiding this comment.
That way if a test fails AND has logs, we won't focus on both why the test failed and the fact that the test logged errors/warnings, so that devs can focus on the test failure first, which in most cases will also resolve the logs. Also good for agents I suspect.
| "typescript.enablePromptUseWorkspaceTsdk": true, | ||
| "typescript.tsdk": "node_modules/typescript/lib", | ||
| "js/ts.tsdk.promptToUseWorkspaceVersion": true, | ||
| "js/ts.tsdk.path": "node_modules/typescript/lib", |
Collaborator
Author
There was a problem hiding this comment.
Turns out these two are deprecated in favor of these new settings.
I had odd eslint warnings in vscode but not in the cli, that's how I found out.
amanmahajan7
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.