Issue/9057 super user cannot run collectors#799
Merged
v-dumas merged 1 commit intosupport/3.2from Mar 26, 2026
Merged
Conversation
Molkobain
reviewed
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to address an issue where super users cannot run collectors by modifying the ModuleInstallation class to be subject to profile-based permissions. However, the PR also includes several unrelated changes.
Changes:
- Added
grant_by_profilecategory to ModuleInstallation class and added it to the AdminSysReadOnly group for SuperUser profile - Added new permissions for Ticketing and Incident groups in the SuperUser profile
- Added row-gap styling to multi-column layout component
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup/moduleinstallation.class.inc.php | Adds grant_by_profile category to make ModuleInstallation subject to profile-based permissions |
| datamodels/2.x/itop-profiles-itil/datamodel.itop-profiles-itil.xml | Adds ModuleInstallation to AdminSysReadOnly group; adds unrelated Ticketing and Incident permissions |
| css/backoffice/layout/multi-column/_multi-column.scss | Adds row-gap styling to multi-column layout (unrelated UI improvement) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@v-dumas please assign yourself to your PRs. Also, if you don't fill the template, please remove everything and just put "Internal". |
Molkobain
requested changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR attempts to address an issue where SuperUser cannot run collectors as it requires to get objects from the ModuleInstallation class.
Changes:
grant_by_profilecategory to ModuleInstallation class and added it to the AdminSysReadOnly group for SuperUser profileReviewed changes
grant_by_profilecategory to make ModuleInstallation subject to profile-based permissions