Various improvements for TitleColorMatch #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buthed010203
commented
Jul 9, 2023
azuravian/TitleColorMatch.py
Outdated
| stroke_color = 'black' if luminance > 50 else 'white' | ||
| else: | ||
| title_color = self.TITLE_COLOR | ||
| stroke_color = 'black' |
Author
There was a problem hiding this comment.
I thought about this earlier and now I'm even more certain that there should probably be a STROKE_COLOR var thats used here
Owner
There was a problem hiding this comment.
What would the variable be for?
Author
|
I need to nail down a better minimum luminosity still (perhaps it would be a good idea to add a color difference calculation too?). Also some of the code returns on the first loop of the luminosity check every time even if its too low, I will fix that. |
Other cards use this variable. Changing for consistency
Shows without logos will still have the rest of the card applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably have the font_color set to
autoby default since that's the main appeal of using this over GradientLogoTitleCard.