fix(exporter): no sound in guitar 8 pro RSE #2456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2455
Proposed changes
Fixed GP file export to correctly generate RSE audio configuration. GP files exported from alphaTab were missing the
<Name>element and incorrectly using<Pitched>element, causing no sound when playing with RSE audio in Guitar Pro.Root cause:
Exported GP files had
<Pitched>Pitched</Pitched>instead of<Name>Pitched</Name>in the RSE audio configuration, which prevented Guitar Pro from properly loading the RSE sound bank.Change:
Testing/Debugging process:
score.gpifXML structure<Name>Pitched</Name>while the non-working track had<Pitched>Pitched</Pitched>After applying this fix, exported GP files now play correctly with RSE audio in Guitar Pro.
Checklist
Further details