fix: prevent double clipboard alert on copy action#1265
Merged
HardeepAsrani merged 6 commits intodevelopmentfrom Mar 10, 2026
Merged
fix: prevent double clipboard alert on copy action#1265HardeepAsrani merged 6 commits intodevelopmentfrom
HardeepAsrani merged 6 commits intodevelopmentfrom
Conversation
render-facade.js could be loaded more than once (registered under multiple handles when charts from different libraries appear on the same page). The copy ClipboardJS instance had no guard against double-initialization, causing the success alert to fire twice. Added vizClipboard2 guard to mirror the existing vizClipboard1 pattern already used for the shortcode copy button.
HardeepAsrani
added
the
pr-checklist-skip
pirate-bot
added
pr-checklist-complete
Contributor
Soare-Robert-Daniel
approved these changes
Mar 6, 2026
Soare-Robert-Daniel
approved these changes
Mar 10, 2026
Contributor
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render-facade.js could be loaded more than once (registered under multiple handles when charts from different libraries appear on the same page). The copy ClipboardJS instance had no guard against double-initialization, causing the success alert to fire twice.
Added vizClipboard2 guard to mirror the existing vizClipboard1 pattern already used for the shortcode copy button.
Will affect visual aspect of the product
YES/NO
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/530.