Skip to content

Fixed infinite scroll on archive page#4486

Open
girishpanchal30 wants to merge 2 commits intodevelopmentfrom
bugfix/pro/3151
Open

Fixed infinite scroll on archive page#4486
girishpanchal30 wants to merge 2 commits intodevelopmentfrom
bugfix/pro/3151

Conversation

@girishpanchal30
Copy link
Copy Markdown
Contributor

Summary

Created the tax_query for the infinite scroll on the archive page.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/3151

@girishpanchal30 girishpanchal30 requested a review from Copilot March 31, 2026 07:11
@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 31, 2026
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 31, 2026
@pirate-bot
Copy link
Copy Markdown
Collaborator

pirate-bot commented Mar 31, 2026

Plugin build for 581b173 is ready 🛎️!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix infinite scroll on taxonomy archive pages by ensuring the REST infinite-scroll request includes the necessary taxonomy filtering information.

Changes:

  • Adjusts localized infinite-scroll query payload for taxonomy archives by injecting a post_type.
  • Extends infinite-scroll query sanitization to construct a tax_query from taxonomy query vars.
  • Updates the sanitization docblock messaging around expensive query vectors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Soare-Robert-Daniel
Copy link
Copy Markdown
Contributor

@girishpanchal30, to confirm, the regression was because you missed the taxonomy handling on 721d2ad? I was wondering, since in that commit you removed the tax_query from $dangerous_keys, with this PR, you introduce something to use it or some sort of it.

@girishpanchal30
Copy link
Copy Markdown
Contributor Author

@Soare-Robert-Daniel Yes, I missed the taxonomy handling in 721d2ad. Because of that, WP_Query was fetching posts on the archive page. I’ve now added a tax_query for the taxonomy to correctly query custom post types on the archive page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants