pressKey: Fixing @param string|array<string|string> $chars#138
Merged
TavoNiievez merged 3 commits intoCodeception:masterfrom Dec 15, 2024
Merged
pressKey: Fixing @param string|array<string|string> $chars#138TavoNiievez merged 3 commits intoCodeception:masterfrom
pressKey: Fixing @param string|array<string|string> $chars#138TavoNiievez merged 3 commits intoCodeception:masterfrom
Conversation
Member
Author
|
@TavoNiievez Can you merge this please? |
TavoNiievez
approved these changes
Dec 15, 2024
Member
Author
|
Thanks! Do you know why the tests are failing for all PRs? |
|
Umm, guys, But the definition implies something like this: So I would suggest to just put |
Member
Author
|
Indeed, sorry, looks like I thought the syntax was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docblock was changed in #88, and was probably intended to be
string|string[]