Fixed for current version of goaop#218
Open
DrDub wants to merge 1 commit intoCodeception:masterfrom
Open
Conversation
Contributor
|
#219 fixes current goaop compatibility, even though this PR is still useful for future developments. |
Author
|
#219 is not enough, you'll at the very least need this change from this PR: https://github.com/Codeception/AspectMock/pull/218/changes#diff-9381760f82ecb0e4a1af60cfdae980de064dfd197f83ca451eae5cb09bd8da9cR37 (the interface has changed) |
Contributor
|
@DrDub You mean the signature for class #219 uses the tagged stable version (3.1.1) where the interface hasn't changed: https://github.com/goaop/framework/blob/3.1.1/src/Core/AspectKernel.php#L213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Recent changes in the master branch of
goap/frameworkpushedsymfony/finderforward and this branch no longer works.Updating the dependencies brought issues with Specify and PHPUnit 10.
From what I can tell, that is not solved. This is unrelated to this project, just it tests so I commented out the Specify calls, leaving the asserts as part of the base test function.
A fix for #201 is also included. Tested with PHP 8 under Debian Trixie.