London | 26-SDC-Mar | Jamal Laqdiem | Sprint 2 | shell pipelines exercises#367
Open
jamallaqdiem wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
London | 26-SDC-Mar | Jamal Laqdiem | Sprint 2 | shell pipelines exercises#367jamallaqdiem wants to merge 4 commits intoCodeYourFuture:mainfrom
jamallaqdiem wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Fix expected output in sed exercise instructions (CodeYourFuture#353)
jamallaqdiem
added
Needs Review
SlideGauge
reviewed
May 2, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Could you adjust the settings of your editor? All the files are missing the trailing end of line.
|
|
||
| # TODO: Write a command to output the names of the files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters. | ||
| # Your output should contain 7 files. | ||
| ls -1 sample-files | grep '^[A-Z][a-z]*$' No newline at end of file |
There was a problem hiding this comment.
The regex '^[A-Z][a-z]*$' captures "starts with uppercase, then only lowercase letters." But the task says "doesn't contain any other upper case letters" — it says nothing about restricting digits, dots, hyphens, etc. A filename like Foo.txt or File1 would NOT match your regex even though it satisfies the task requirement.
| # Your output should be the number 7. | ||
| #!/bin/bash | ||
|
|
||
| ls -1 sample-files | grep '^[A-Z][a-z]*$' | wc -l No newline at end of file |
Author
There was a problem hiding this comment.
Thnaks for reviewing, I addressed the issues.
SlideGauge
added
Reviewed
|
Good job, could you do a couple of fixes I pointed out? |
Author
|
I changed the setting to add a trainling end line at save. |
jamallaqdiem
added
the
Needs Review
SlideGauge
added
Complete
|
Nice, review completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed the exercises shell pipelines.