Skip to content

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 1 | Individual Shell Tools#338

Open
enjoy15 wants to merge 7 commits intoCodeYourFuture:mainfrom
enjoy15:individual-shell-tools
Open

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 1 | Individual Shell Tools#338
enjoy15 wants to merge 7 commits intoCodeYourFuture:mainfrom
enjoy15:individual-shell-tools

Conversation

@enjoy15
Copy link

@enjoy15 enjoy15 commented Mar 8, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all exercises

@enjoy15 enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 11, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Mar 21, 2026
Copy link

@SlideGauge SlideGauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall decent work, one small note from me about -lwc and also could you add new lines in the end of files?

# 1 7 39 ../helper-files/helper-2.txt
# 3 19 92 ../helper-files/helper-3.txt
# 5 30 151 total
wc -lwc ../helper-files/*.txt No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen with character count if encoding of our file is non ascii (in ascii each byte equals to a character), but, for example, UTF-8 with exotic characters?

# TODO: Write a command to output just the names of each player along with the total of adding all of that player's scores.
# Your output should contain 6 lines, each with one word and one number on it.
# The first line should be "Ahmed 15". The second line should be "Basia 37"
awk '{sum = 0; for (i = 3; i <= NF; i++) sum += $i; print $1, sum}' scores-table.txt No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct choice to start from 3, like!

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants