Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 4 | Implement shell tools (cat, ls, wc) in Python#263
Open
RahwaZeslusHaile wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
OracPrime
reviewed
Dec 29, 2025
OracPrime
left a comment
There was a problem hiding this comment.
This code is good, well done. If I wanted to get picky, I say that you should be outputting any error messages to stderr not stdout - you should be able to find do different ways of doing this in Python. However just consider that for future work - I'll flag this as complete as is.
Author
|
Thank you @OracPrime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 4 | Implement shell tools (cat, ls, wc) in Python
Learners, PR Template
Self checklist
Changelist
Questions
Thank you for your time reviewing this work