Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 | Individual shell tools#189
Open
sheida-shab wants to merge 8 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 25-SDC-Nov | Sheida Shabankari | Sprint 1 | Individual shell tools#189sheida-shab wants to merge 8 commits intoCodeYourFuture:mainfrom
sheida-shab wants to merge 8 commits intoCodeYourFuture:mainfrom
Conversation
sheida-shab
added
Needs Review
LonMcGregor
reviewed
Nov 19, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
|
|
||
| # TODO: Write a command to output the number of lines in dialogue.txt that contain the word Doctor (regardless of case). | ||
| # The output should be exactly the number 9. | ||
| rep -ic Doctor dialogue.txt No newline at end of file |
There was a problem hiding this comment.
Did you test this before submitting? Did it work?
Author
There was a problem hiding this comment.
Hello,thanks for your review.
Sorry it was a typo mistake and I fix it.
I tested in terminal and when I copied that,this mistake happened.
LonMcGregor
added
Reviewed
sheida-shab
added
Needs Review
|
Great, it's easy to make mistakes like that, so always be sure to test before opening a PR. this is complete now! |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist