West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | Coursework/sprint-3/2-practice-tdd#799
Closed
Baba05206 wants to merge 7 commits intoCodeYourFuture:mainfrom
Closed
Conversation
Baba05206
added
📅 Sprint 3
cjyuan
reviewed
Oct 28, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The tests are very comprehensive. Nicely done.
cjyuan
added
Reviewed
…tests for clarity
… test cases for clarity and coverage
Baba05206
added
the
Needs Review
cjyuan
reviewed
Oct 30, 2025
Comment on lines
+3
to
+8
| if (stringOfCharacters === null || stringOfCharacters === undefined) { | ||
| throw new Error("The input string cannot be null or undefined."); | ||
| } | ||
| if (typeof stringOfCharacters !== "string") { | ||
| throw new Error("The input string must be a string type."); | ||
| } |
Contributor
There was a problem hiding this comment.
Why treat null and undefined differently from other non-string types?
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed the three practice exercises in 2-practice-tdd