West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Implement and rewrite tests#787
Closed
Iswanna wants to merge 10 commits intoCodeYourFuture:mainfrom
Closed
West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Implement and rewrite tests#787Iswanna wants to merge 10 commits intoCodeYourFuture:mainfrom
Iswanna wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
…hrow an error for invalid cards
Iswanna
added
Needs Review
Iswanna
changed the title
Iswanna
changed the title
Iswanna
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This pull request involves modifications to two directories:
Implement directory: I added assertions using
console.assertand built the program case by case.Rewrite-tests-with-Jest directory: I rewrote the existing test cases using Jest and ran
npm testto verify the implementation of the getCardValue function.Questions
Hi. Please could you review my PR? I’d really appreciate your feedback?