Sheffield | 26-Jan-ITP | Mona-Eltantawy | Sprint 3| Sprint 3/1 implement and rewrite testes#1275
Open
Mona-Eltantawy wants to merge 24 commits intoCodeYourFuture:mainfrom
Open
Conversation
…ge values using assert function
…ative and equal numbers.
…ed the code ensuring that all tests passed.
…undary and invalid cases.
…etCardValue function.
…character occurs in a string
…cases nd, th, st, and rd.
- Continue testing and implementing getOrdinalNumber for additional cases. - Write tests using Jest .
…e than 1, and to give empty out put for (0) and 'invalid count' output for negative counts.
…e code. - deleted the const greetingStr = greeting + ", " + name + "!"; because it is a redundant code that repeated already int the return function.
aslo removed the logPets function as it doesn't called.
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Deleted the file because not required in the PR
deleted the file because not required in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist