London | 26-ITP-Jan | Divine Mankrado | Sprint 3 | Practice TDD#1239
Open
divinmank wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Divine Mankrado | Sprint 3 | Practice TDD#1239divinmank wants to merge 7 commits intoCodeYourFuture:mainfrom
divinmank wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
divinmank
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
divinmank
added
the
Needs Review
cjyuan
reviewed
Mar 14, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Function implementation is correct.
-
A few tests could use some improvement.
Comment on lines
+26
to
+38
| test("should return 0 if the character does not exist in the string", () => { | ||
| const str = "hello"; | ||
| const char = "z"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }); | ||
|
|
||
| test("should return 0 if the character does not exist in the string", () => { | ||
| const str = "hello"; | ||
| const char = "z"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }); |
| // Case 4: Numbers ending with 11, 12, 13, or any other digit | ||
| // When the number ends with 11, 12, 13, or any digit not 1, 2, or 3, | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for numbers ending with 11, 12, 13, or other digits", () => { |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... or other digits", it may be unclear what "other digits" actually refers to.
Can you revise the test description to make it more informative?
Contributor
There was a problem hiding this comment.
Could consider testing a few more samples in this script - higher chance to detect bugs in code.
The original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made,
we could add test cases to convey this. For examples,
- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets
cjyuan
added
Reviewed
Author
|
Thanks for the feedback!
|
…/divinmank/Module-Structuring-and-Testing-Data into coursework/sprint-3-practice-tdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Finished the practice TDD segment of sprint 3.