London | ITP-JAN-2026 | Said Fayaz Sadat | Sprint 3 | coursework/sprint-3/implement-and-rewrite-tests

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -15,7 +15,28 @@
 // execute the code to ensure all tests pass.
 
 function getAngleType(angle) {
-  // TODO: Implement this function
+  if (angle > 0 && angle < 90) {
+    return "Acute angle";
+  }
+  if (angle === 90) {
+    return "Right angle";
+  }
+  if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  }
+  if (angle === 180) {
+    return "Straight angle";
+  }
+  if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  }
+  if (angle === 360) {
+    return "Straight angle"; 
+  }
+  if (angle === 1) {
+    return "Acute angle"; 
+  }
+  return "Invalid angle";
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -35,3 +56,21 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: Identify Right Angles
 const right = getAngleType(90);
 assertEquals(right, "Right angle");
+
+const acute = getAngleType(45);
+assertEquals(acute, "Acute angle");
+
+const obtuse = getAngleType(135);
+assertEquals(obtuse, "Obtuse angle");
+
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
+
+const reflex = getAngleType(270);
+assertEquals(reflex, "Reflex angle");
+
+const invalid = getAngleType(-45);
+assertEquals(invalid, "Invalid angle");
+
+const invalid2 = getAngleType(361);
+assertEquals(invalid2, "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,14 +11,20 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+  if (denominator === 0) {
+    return false;
+  }
+
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
+module.exports = isProperFraction;
+
 // The line below allows us to load the isProperFraction function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
-module.exports = isProperFraction;
+//module.exports = isProperFraction;
 
-// Here's our helper again
+/* Here's our helper again
 function assertEquals(actualOutput, targetOutput) {
   console.assert(
     actualOutput === targetOutput,
@@ -30,4 +36,14 @@ function assertEquals(actualOutput, targetOutput) {
 // What combinations of numerators and denominators should you test?
 
 // Example: 1/2 is a proper fraction
+/*
 assertEquals(isProperFraction(1, 2), true);
+assertEquals(isProperFraction(2, 1), false);
+assertEquals(isProperFraction(0, 1), true);
+assertEquals(isProperFraction(-1, 2), false);
+assertEquals(isProperFraction(1, -2), false);
+assertEquals(isProperFraction(-1, -2), false);
+assertEquals(isProperFraction(3, 4), true);
+assertEquals(isProperFraction(4, 3), false);
+
+*/

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,7 +22,32 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
-  // TODO: Implement this function
+  const validRanks = ["A","2","3","4","5","6","7","8","9","10","J","Q","K"];
+  const validSuits = ["♠","♥","♦","♣"];
+
+  // Check type
+  if (typeof card !== "string") {
+    throw new Error("Invalid card string");
+  }
+
+  const suit = card.slice(-1);
+  const rank = card.slice(0, -1);
+
+  // Validate rank and suit
+  if (!validRanks.includes(rank) || !validSuits.includes(suit)) {
+    throw new Error("Invalid card string");
+  }
+
+  // Compute value
+  if (rank === "A") {
+    return 11;
+  }
+
+  if (["J", "Q", "K"].includes(rank)) {
+    return 10;
+  }
+
+  return parseInt(rank);
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -39,7 +64,7 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9♠"), 9);
+/* assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
 try {
@@ -50,3 +75,12 @@ try {
 } catch (e) {}
 
 // What other invalid card cases can you think of?
+assertEquals(getCardValue("A"), 11); // Missing suit
+try {
+  getCardValue("11♠"); // Invalid rank
+  console.error("Error was not thrown for invalid rank");
+} catch (e) {}
+
+try {  getCardValue("9X"); // Invalid suit
+  console.error("Error was not thrown for invalid suit");
+} catch (e) {} */

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -14,7 +14,43 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
 });
 
 // Case 2: Right angle
+test(`should return "Right angle" when (angle === 90)`, () => {
+  expect(getAngleType(90)).toEqual("Right angle");
+});
+
 // Case 3: Obtuse angles
+test(`should return "Obtuse angle" when (90 < angle < 180)`, () => {
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+  expect(getAngleType(135)).toEqual("Obtuse angle");
+  expect(getAngleType(179)).toEqual("Obtuse angle");
+});
+
 // Case 4: Straight angle
+test(`should return "Straight angle" when (angle === 180)`, () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+
 // Case 5: Reflex angles
+test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(270)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
+});
+
 // Case 6: Invalid angles
+test(`should return "Invalid angle" when angle < 1 `, () => {
+  expect(getAngleType(-1)).toEqual("Invalid angle");
+});
+
+test(`should return "Invalid angle" when angle > 360 `, () => {
+  expect(getAngleType(361)).toEqual("Invalid angle");
+});
+
+// Largest valid angle(boundary case)
+test(`should return "Straight angle" when angle is the maximum valid value (360)`, () => {
+  expect(getAngleType(360)).toEqual("Straight angle");
+});
+ // Smallest valid angle(boundary case)
+test(`should return "Acute angle" when angle is the minimum valid value (1)`, () => {
+  expect(getAngleType(1)).toEqual("Acute angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,7 +4,28 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
-// Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
+
+// Category 1: Numerator is zero
+test("should return true when numerator is zero and denominator is positive", () => {
+  expect(isProperFraction(0, 1)).toBe(true);
+});
+test("should return true when numerator is zero and denominator is negative", () => {
+  expect(isProperFraction(0, -1)).toBe(true);
+});
+
+// Category 2: Proper fractions (numerator < denominator)
+test("should return true when numerator is less than denominator", () => {
+  expect(isProperFraction(1, 2)).toBe(true);
+  expect(isProperFraction(3, 5)).toBe(true);
 });
+
+// Category 3: Improper fractions (numerator >= denominator)
+test("should return false when numerator is greater than or equal to denominator", () => {
+  expect(isProperFraction(2, 1)).toBe(false);
+  expect(isProperFraction(5, 5)).toBe(false);
+});
+
+// Category 4: Denominator is zero
+test("should return false when denominator is zero", () => {
+  expect(isProperFraction(1, 0)).toBe(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -11,10 +11,29 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
+test(`Should return the numeric value for number cards`, () => {
+  expect(getCardValue("2♠")).toEqual(2);
+  expect(getCardValue("10♠")).toEqual(10);
+});
 //   Face Cards (J, Q, K)
+test(`Should return 10 for face cards`, () => {
+  expect(getCardValue("J♠")).toEqual(10);
+  expect(getCardValue("Q♠")).toEqual(10);
+  expect(getCardValue("K♠")).toEqual(10);
+});
 //   Invalid Cards
+test(`Should throw an error for invalid cards`, () => {
+  expect(() => getCardValue("invalid")).toThrow("Invalid card string");
+  expect(() => getCardValue("A")).toThrow("Invalid card string"); // Missing suit
+  expect(() => getCardValue("11♠")).toThrow("Invalid card string"); // Invalid rank
+  expect(() => getCardValue("9X")).toThrow("Invalid card string"); // Invalid suit
+});
 
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
 
+
+
+
+