generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 337
London | 26-ITP-Jan | Alex Okorefe | Sprint 3 | Practice TDD #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex-Os-Dev-Lab
wants to merge
5
commits into
CodeYourFuture:main
Choose a base branch
from
Alex-Os-Dev-Lab:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0141efb
(count.js) Implement character counting logic in countChar function a…
Alex-Os-Dev-Lab ac7e1c8
Implement getOrdinalNumber function to return correct ordinal suffixes
Alex-Os-Dev-Lab 1a5ddc6
Add tests for ordinal number suffixes in getOrdinalNumber function
Alex-Os-Dev-Lab d4aba95
Implement repeatStr function to handle string repetition based on inp…
Alex-Os-Dev-Lab 5939d12
Add tests for edge cases in repeatStr function: handle count of 1, 0,…
Alex-Os-Dev-Lab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,17 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| // 1. Assign a variable to keep track of the count | ||
| let count = 0; | ||
|
|
||
| // 2. Loop through all chars in the string | ||
| for (let char = 0; char < stringOfCharacters.length; char++) { | ||
| // 3. Check if the current char matches the one we are looking for | ||
| if (stringOfCharacters[char] === findCharacter) { | ||
| count++; // If it's a match, add 1 to our tally | ||
| } | ||
| } | ||
|
|
||
| // 4. Return the final tally after the loop finishes | ||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,26 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| // Calculate the remainder when divided by 100 to check for 11, 12, 13 | ||
| const lastTwoDigits = number % 100; | ||
|
|
||
| // Calculate the remainder when divided by 10 to get the single last digit | ||
| const lastDigit = number % 10; | ||
|
|
||
| // 1. The "teen" exceptions (11th, 12th, 13th) | ||
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { | ||
| return number + "th"; | ||
| } | ||
|
|
||
| // 2. Apply standard rules based on last digit | ||
| if (lastDigit === 1) { | ||
| return number + "st"; | ||
| } else if (lastDigit === 2) { | ||
| return number + "nd"; | ||
| } else if (lastDigit === 3) { | ||
| return number + "rd"; | ||
| } else { | ||
| // Cover 0, 4, 5, 6, 7, 8, and 9 | ||
| return number + "th"; | ||
| } | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,25 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(stringToRepeat, numberOfRepetitions) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| // Handle count of 0 | ||
| if (numberOfRepetitions === 0) { | ||
| return ""; | ||
| } | ||
|
|
||
| // Handle count of 1 | ||
| if (numberOfRepetitions === 1) { | ||
| return stringToRepeat; | ||
| } | ||
|
|
||
| // Handle multiple repetitions (> than 1) | ||
| if (numberOfRepetitions > 1) { | ||
| let finalString = ""; | ||
|
|
||
| // loop for repeating the string and concatenating it to the final string | ||
| for (let repetition = 0; repetition < numberOfRepetitions; repetition++) { | ||
| finalString = finalString + stringToRepeat; | ||
| } | ||
|
|
||
| return finalString; | ||
| } | ||
| } | ||
|
|
||
| module.exports = repeatStr; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider testing a few more samples in this script - higher chance to detect bugs in code.
The original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made,
we could add test cases to convey this. For examples,