London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | Implement and rewrite tests#1207

Closed

Zadri415 wants to merge 13 commits intoCodeYourFuture:mainfrom

Zadri415:origin/coursework/sprint-3

Zadri415 commented Mar 7, 2026 •

edited

Loading

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all of the exercises required.

Questions

None at the moment.

Zadri415 added 13 commits

November 8, 2025 21:20


          Interpret error message and explain cause in 1-key-errors/0.js

0fc35ed


          Fix and explain redeclaration SyntaxError in convertToPercentage (1-k…

f4e38d3

…ey-errors/1.js)


          Fix and explain 'unexpected number' SyntaxError in square() (1-key-er…

8a162e3

…rors/2.js)


          Fix undefined return in sum() and explain cause (2-mandatory-debug/0.js

2bf3487


           add changes to 2-mandatory-debug/0.js

54ca144


          add prediction and explanation

ff14721


          predict the output

97dc683


          add and explain calculateBMI() function to compute BMI to one decimal…

2f8d74e

… place


          add using String.toUpperCase() to convert greeting to uppercase

c52e087


          turn interpret/to-pounds.js into a reuseable block of code

0de1e19


          add formatTimeDisplay() answers explaining pad() calls and returning …

a451eda

…values


          add and test formatAs12HourClock function with passing assertions

083a9d2


          Sprint 3: implement solutions and rewrite tests with Jest

98d1215

github-actions bot commented Mar 7, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Zadri415 added the Needs Review label

github-actions bot commented Mar 7, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

Zadri415 changed the title ~~London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | Implement and rewrite tests~~ London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | coursework implement and rewrite tests

github-actions bot commented Mar 7, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Zadri415 added the Needs Review label

github-actions bot commented Mar 7, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

Zadri415 added the Needs Review label

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Zadri415 changed the title ~~London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | coursework implement and rewrite tests~~ London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | implement and rewrite tests

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Zadri415 changed the title ~~London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | implement and rewrite tests~~ London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | Implement and rewrite tests

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Zadri415 added the Needs Review label

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

Zadri415 added 📅 Sprint 3 Needs Review labels

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Mar 7, 2026

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Contributor

cjyuan commented Mar 7, 2026

Sprint-3 exercises need to be submitted in separate PRs (1 PR for each backlog):

Required
- Complete Sprint 3 implement and rewrite tests coursework
- Complete Sprint 3 practice TDD coursework
Optional
- Complete Sprint 3 stretch coursework
- Refactoring Dead Code

Otherwise the GitHub validation bot will complain and prevent you from adding the "Needs Review" label to your PR.

Can you update this PR (or close it) and then resubmit your work in separate PRs?

Author

Zadri415 commented Mar 9, 2026

Sprint-3 exercises need to be submitted in separate PRs (1 PR for each backlog):

Required

Complete Sprint 3 implement and rewrite tests coursework

Complete Sprint 3 practice TDD coursework

Optional

Complete Sprint 3 stretch coursework

Refactoring Dead Code

Otherwise the GitHub validation bot will complain and prevent you from adding the "Needs Review" label to your PR.

Can you update this PR (or close it) and then resubmit your work in separate PRs?

Sprint-3 exercises need to be submitted in separate PRs (1 PR for each backlog):

Required

Complete Sprint 3 implement and rewrite tests coursework

Complete Sprint 3 practice TDD coursework

Optional

Complete Sprint 3 stretch coursework

Refactoring Dead Code

Otherwise the GitHub validation bot will complain and prevent you from adding the "Needs Review" label to your PR.

Can you update this PR (or close it) and then resubmit your work in separate PRs?

Sprint-3 exercises need to be submitted in separate PRs (1 PR for each backlog):

Required

Complete Sprint 3 implement and rewrite tests coursework

Complete Sprint 3 practice TDD coursework

Optional

Complete Sprint 3 stretch coursework

Refactoring Dead Code

Otherwise the GitHub validation bot will complain and prevent you from adding the "Needs Review" label to your PR.

Can you update this PR (or close it) and then resubmit your work in separate PRs?

Noted. I'll close this PR.

Zadri415 closed this

Zadri415 deleted the origin/coursework/sprint-3 branch

March 9, 2026 12:43

Zadri415 restored the origin/coursework/sprint-3 branch

March 9, 2026 22:11

Zadri415 deleted the origin/coursework/sprint-3 branch

March 9, 2026 22:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels