Sheffield | 26-Jan-ITP | Karim Mhamdi | Sprint 2 | Coursework/sprint-2#1204
Open
KKtech06 wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP | Karim Mhamdi | Sprint 2 | Coursework/sprint-2#1204KKtech06 wants to merge 3 commits intoCodeYourFuture:mainfrom
KKtech06 wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
KKtech06
added
the
Needs Review
cjyuan
reviewed
Mar 7, 2026
Comment on lines
+8
to
+10
| function toPounds(pence) { | ||
| return "£" + (pence / 100).toFixed(2); | ||
| } |
Contributor
There was a problem hiding this comment.
The code in Sprint-1 takes as "input" a pence string in the form "123p" instead of a number 123. Can you update your function to match that behavior?
Author
There was a problem hiding this comment.
Thank you for spotting the error CJ I have fixed it and hopefully now the function matches the behaviour :)
cjyuan
added
Reviewed
KKtech06
added
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
Contributor
|
Can you update the Markdown in the PR description to make the checkboxes look like this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed all the tasks in Sprint-2 and I have created a Coursework/Sprint-2 branch
Questions
N/A