London | 26-Jan-ITP | Shuheda Begum | Sprint 1 | Sprint-1

[codebyshay]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Complete Sprint 1 coursework

Questions

Any changes to be made?

[cjyuan]

All good.

Note:
You had a reviewed Sprint-1 PR (#1066) but was closed because of some accident.

I assume the work here is a continuation of the work you had in that PR .
You could mention this in the PR description and even tag me to continue reviewing it (unless you prefer your PR to be reviewed by someone else). Otherwise you may have to wait for a long time before your PR get reviewed because there are many PRs waiting to be reviewed currently.

[codebyshay]

Hi @cjyuan, unfortunately I'm not sure how, but the work i did on sprint 2 somehow merged with this PR when I tried to push my work to remote. When i tried to fix it, I accidentally erased everything...
Thank you for taking your time for re-reviewing my work, I appreciate it. I didn't realise I can tag you on a new PR if you hadn't yet reviewed it, great to know.

[cjyuan]

Trainees make mistake with Git from time to time. It is better to experience them now in the course than in actual work space. Hope you figure out how to avoid what you did.

I reviewed your Sprint-1 PR and this is still your Sprint-1 PR. Because it is basically the same code, tagging me to continue reviewing the code seems like a natural continuation.

Don't tag reviewer on a PR that they hadn't yet review though.