Skip to content

Scotland | ITP JAN-2026 | Tuan Nguyen | Sprint 2 | Comparisons-assertions-breaking-down-problems-sprint-2#1183

Open
Jacknguyen4438 wants to merge 2 commits intoCodeYourFuture:mainfrom
Jacknguyen4438:comparisons-assertions-breaking-down-problems-sprint-2
Open

Scotland | ITP JAN-2026 | Tuan Nguyen | Sprint 2 | Comparisons-assertions-breaking-down-problems-sprint-2#1183
Jacknguyen4438 wants to merge 2 commits intoCodeYourFuture:mainfrom
Jacknguyen4438:comparisons-assertions-breaking-down-problems-sprint-2

Conversation

@Jacknguyen4438
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have fished mandatory course work for sprint 2 module 2 and ready to be review.

Questions

No question for this PR.

@github-actions

This comment has been minimized.

@Jacknguyen4438 Jacknguyen4438 changed the title Scotland | ITP JAN-2026 | Tuan Nguyen | Sprint2 | Comparisons-assertions-breaking-down-problems-sprint-2 Scotland | ITP JAN-2026 | Tuan Nguyen | Sprint-2 | Comparisons-assertions-breaking-down-problems-sprint-2 Mar 5, 2026
@github-actions

This comment has been minimized.

@Jacknguyen4438 Jacknguyen4438 changed the title Scotland | ITP JAN-2026 | Tuan Nguyen | Sprint-2 | Comparisons-assertions-breaking-down-problems-sprint-2 Scotland | ITP JAN-2026 | Tuan Nguyen | Sprint 2 | Comparisons-assertions-breaking-down-problems-sprint-2 Mar 5, 2026
@Jacknguyen4438 Jacknguyen4438 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 5, 2026
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 8, 2026
/*
The main reason why the capitalise function have a not define error because the the str variable have been declare in the parameter
inside the function, the str variable is re-declare again that will break the rule of how variable work.
*/
Copy link

@A-O-Emmanuel A-O-Emmanuel Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for example, the proper way to write this statement will be: inside the function, the str variable is redeclared, which breaks the rule of how variables work.

There are other examples in your work where wrong sentences are used.

The resources contained in this Link should help: BBC Learning English

Again, good Job!

Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with what you have done here, good job!
I will suggest you work on your English a bit more.

@A-O-Emmanuel A-O-Emmanuel added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 8, 2026
@Jacknguyen4438
Copy link
Author

@A-O-Emmanuel Hello Emmanuel, I am very grateful for you time reading my PR. I understand that my English in this sprint PR is broken, because I explain base on what I can understand. So even though this PR is completed I will see what need to be change base on your review and fix it because I think is a good practice to read, evaluate, and fix the error for future PR of other course work. One again I'm very grateful for your help and I hope to received further review from you.

@A-O-Emmanuel
Copy link

You're welcome @Jacknguyen4438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants