Skip to content

Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | Refactoring Dead Code#1179

Open
MehrozMunir wants to merge 5 commits intoCodeYourFuture:mainfrom
MehrozMunir:coursework/sprint-3-dead-code
Open

Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | Refactoring Dead Code#1179
MehrozMunir wants to merge 5 commits intoCodeYourFuture:mainfrom
MehrozMunir:coursework/sprint-3-dead-code

Conversation

@MehrozMunir
Copy link

@MehrozMunir MehrozMunir commented Mar 5, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Made changes in exercise files to remove the dead code.

@github-actions

This comment has been minimized.

@MehrozMunir MehrozMunir changed the title Manchester | Mehroz Munir | Sprint 3 | Refactoring Dead Code Manchester | Mehroz Munir | Sprint 3 | RefactoringDeadCode Mar 5, 2026
@github-actions

This comment has been minimized.

@MehrozMunir MehrozMunir changed the title Manchester | Mehroz Munir | Sprint 3 | RefactoringDeadCode Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | RefactoringDeadCode Mar 5, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@MehrozMunir MehrozMunir changed the title Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | RefactoringDeadCode Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 3 | Refactoring Dead Code Mar 5, 2026
@MehrozMunir MehrozMunir added Optional This is an optional task to be attempted once trainees have completed the core tasks 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 5, 2026
@SlideGauge SlideGauge added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Mar 14, 2026
console.log(greetingMessage); // 'hello, Aman!'


// adding comment in exercise 1 No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a stray comment, not needed in the task


console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log

//added a new comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray comments, not needed

}

testName = "Aman";
const testName = "Aman";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch "Jerry" value was not used

@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 14, 2026
@SlideGauge
Copy link

Just a tiny request, could you remove stray comments?

@MehrozMunir
Copy link
Author

Just a tiny request, could you remove stray comments?

Sorry, my bad, I added them while giving a demo and forgot to remove them. Removed now.
Thank you.

@MehrozMunir MehrozMunir added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 15, 2026
@SlideGauge SlideGauge added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 15, 2026
@SlideGauge
Copy link

Done, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. Optional This is an optional task to be attempted once trainees have completed the core tasks 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants