Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 3 | Practice TDD#1175
Open
dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 3 | Practice TDD#1175dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Self checklist - [X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title - [X] My changes meet the requirements of the task - [X] I have tested my changes - [X] My changes follow the [style guide](https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/) ## Changelist Briefly explain your PR. Have made changes to the file as per the coursework
This comment has been minimized.
This comment has been minimized.
dcostaprakash
added
the
Needs Review
cjyuan
reviewed
Mar 14, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Function implementation is correct
-
Some test descriptions could be made clearer
Comment on lines
+25
to
+30
| test("should return 0 when the character is not found", () => { | ||
| const str = "hello"; | ||
| const char = "z"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could consider testing a few more samples in this script - higher chance to detect bugs in code.
The original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made,
we could add test cases to convey this. For examples,
- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets
Author
There was a problem hiding this comment.
Got it. I have added both the test cases. Thank you
cjyuan
added
Reviewed
Author
|
Have modified the descriptions in the TDD to make the test cases more clear. Thank you |
dcostaprakash
added
Needs Review
Contributor
|
LGTM. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Completed all the tasks as per the coursework