Skip to content

Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | Structuring and Testing Data#1173

Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984:coursework/sprint-3-implement-and-rewrite
Open

Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | Structuring and Testing Data#1173
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984:coursework/sprint-3-implement-and-rewrite

Conversation

@mahmoudshaabo1984
Copy link

@mahmoudshaabo1984 mahmoudshaabo1984 commented Mar 4, 2026

  • I have tested my changes

  • My changes follow the style guide

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title

  • My changes meet the requirements of the task

Summary of work:

Completed all mandatory implementation exercises in the implement directory:

1-get-angle-type.js: Implemented logic for identifying angle types with comprehensive assertions.

2-is-proper-fraction.js: Implemented logic using Math.abs and handled edge cases like zero denominators.

3-get-card-value.js: Implemented playing card value logic with robust error handling for invalid inputs.

Successfully rewrote all tests using the Jest framework in the rewrite-tests-with-jest directory.

Verified that all tests pass with 100% success rate using npm test.

Personal Note:

Hi team, 👋
I'm excited to submit my work for Sprint 3! This week was a great leap forward, especially moving from basic assertions to using a professional testing framework like Jest.
I particularly enjoyed learning how to test for thrown errors using .toThrow() in the card value exercise. I have made sure that my code is clean, well-commented, and follows all the criteria we discussed in the testing guide.
Looking forward to your feedback!
Thank you,
Mahmoud

@mahmoudshaabo1984 mahmoudshaabo1984 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Note: The markdown syntax for checked checkboxes is - [x] instead of [x]. There is a dash character and a space character before [x].

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants