Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | Structuring and Testing Data#1173
Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
cjyuan
reviewed
Mar 6, 2026
Contributor
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
Note: The markdown syntax for checked checkboxes is - [x] instead of [x]. There is a dash character and a space character before [x].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested my changes
My changes follow the style guide
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
Summary of work:
Completed all mandatory implementation exercises in the implement directory:
1-get-angle-type.js: Implemented logic for identifying angle types with comprehensive assertions.
2-is-proper-fraction.js: Implemented logic using Math.abs and handled edge cases like zero denominators.
3-get-card-value.js: Implemented playing card value logic with robust error handling for invalid inputs.
Successfully rewrote all tests using the Jest framework in the rewrite-tests-with-jest directory.
Verified that all tests pass with 100% success rate using npm test.
Personal Note:
Hi team, 👋
I'm excited to submit my work for Sprint 3! This week was a great leap forward, especially moving from basic assertions to using a professional testing framework like Jest.
I particularly enjoyed learning how to test for thrown errors using .toThrow() in the card value exercise. I have made sure that my code is clean, well-commented, and follows all the criteria we discussed in the testing guide.
Looking forward to your feedback!
Thank you,
Mahmoud