London | 26-ITP-Jan | Divine Mankrado | Sprint 2 | Sprint-2 by divinmank · Pull Request #1169 · CodeYourFuture/Module-Structuring-and-Testing-Data

divinmank · 2026-03-04T18:03:08Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I edited errors as prompted and added comments explaining some of the code.

Theoreoluwa · 2026-03-07T16:22:37Z

Sprint-2/1-key-errors/0.js

+// =============> I've given the variable a new name, newStr, to avoid redclaring the variable.
+// =============> function capitalise(str) {
+//  let newStr = `${str[0].toUpperCase()}${str.slice(1)}`;
+//  return newStr;


This is a way to do it. Is there a better way to do it in one line without redeclaring a variable within the function?

Yes. This is the other way to do it. Should I update my code with this?
function capitalise(str) {
return str[0].toUpperCase() + str.slice(1);
}

Theoreoluwa · 2026-03-07T16:28:15Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
    // return the BMI of someone based off their weight and height
+    return (weight/(height**2)).toFixed(1);
 }


Is there a better way to write the code to make it more readable? Also, look into the bmi calculation to make sure the right calculation is done within your code.

Thanks for the comment! I've updated the code

Theoreoluwa · 2026-03-07T16:30:31Z

Sprint-2/3-mandatory-implement/2-cases.js

+function upperSnakeCase(str){
+    return str.toUpperCase().split(" ").join("_");
+}


Good way to handle some edge cases from the passed argument

Theoreoluwa

Good job so far; you should look through the comments to improve. You also have a task not attended to for this sprint which is in folder 5. Ensure that is done along with your next PR.

kfklein15 · 2026-03-11T10:25:10Z

@divinmank this PR has been reviewed 4 days ago and you still haven't replied. Until you do, this volunteer cannot work on another PR, so you are blocking them. Can you please reply today?

divinmank · 2026-03-11T14:33:47Z

Sorry for the late update - I have made the relevant adjustments. Sorry for any inconveniences caused.

divinmank · 2026-03-11T14:41:59Z

Good job so far; you should look through the comments to improve. You also have a task not attended to for this sprint which is in folder 5. Ensure that is done along with your next PR.

I was under the impression that the 5th task "5-stretch-extend" is optional. Is it mandatory to complete this folder?

Theoreoluwa · 2026-03-11T18:03:28Z

Good job so far; you should look through the comments to improve. You also have a task not attended to for this sprint which is in folder 5. Ensure that is done along with your next PR.

I was under the impression that the 5th task "5-stretch-extend" is optional. Is it mandatory to complete this folder?

I would recommended you should as it helps you. It's quite straightforward for this task.

Theoreoluwa

Well done and keep going! You can take on the stretch task, as it helps you build an understanding of tests as you move on.

github-actions · 2026-03-11T18:06:32Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-03-11T18:06:36Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-2/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

divinmank added 10 commits March 2, 2026 21:59

I have finished KeyErrors 0

0f63b87

Editted key errors 0 to match more closely with what was asked

0f18c37

Finished Key error 2

b286998

Finished mandatory debug

c35ac0c

Finished mandatory debug 1

f5b1cd8

Finished mandatory debug 2

ae15e29

Completed mandatory implement 1

53dfb73

Completed mandatory-implement 2

601f051

Finished mandatory interpret 3

6cb971f

Finished mandatory implement time format

4f0ce61

divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

Remedied unexpected file change in sprint 1

f6eafd0

divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026

Theoreoluwa reviewed Mar 7, 2026

View reviewed changes

Theoreoluwa added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 7, 2026

Theoreoluwa reviewed Mar 7, 2026

View reviewed changes

Theoreoluwa added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 7, 2026

divinmank added 2 commits March 11, 2026 14:30

Updated based on comment from volunteer

925895f

Updated bmi task of mandatory debug

8416a21

Resolved merge conflict in time-format.js

6f10d48

divinmank added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 11, 2026

Merge branch 'main' into acoursework/sprint-2

d2d31ba

Theoreoluwa reviewed Mar 11, 2026

View reviewed changes

Theoreoluwa added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026

divinmank mentioned this pull request Mar 22, 2026

26-ITP-JAN | Structuring and Testing Data | Divine Mankrado divinmank/My-Coursework-Planner#28

Open

Uh oh!

Conversation

divinmank commented Mar 4, 2026

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Theoreoluwa Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

divinmank Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

divinmank Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

kfklein15 commented Mar 11, 2026

Uh oh!

divinmank commented Mar 11, 2026

Uh oh!

divinmank commented Mar 11, 2026

Uh oh!

Theoreoluwa commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Theoreoluwa commented Mar 11, 2026 •

edited

Loading