Manchester | 26-ITP-Jan | Khalidbih | Sprint 3 | Coursework 3 implement and rewrite#1168
Closed
khalidbih wants to merge 6 commits intoCodeYourFuture:mainfrom
Closed
Conversation
…, Ace, and invalid cards
This comment has been minimized.
This comment has been minimized.
khalidbih
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
khalidbih
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
khalidbih
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
khalidbih
changed the title
This comment has been minimized.
This comment has been minimized.
khalidbih
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
khalidbih
changed the title
khalidbih
added
the
Needs Review
cjyuan
reviewed
Mar 14, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
This branch is 10 commits behind the upstream branch (CYF's main).
Some of the files in Sprint-3/1-implement-and-rewrite-tests/ have been updated, and some requirements have changed a bit. Can you update your current PR branch? There maybe conflicts which you may need to resolve.
Alternatively, you can update your main branch, create a new branch, transfer your files there, made some changes based on the new spec, and then open a new PR, tag me in the new PR, and close this PR. (This approach is probably easier)
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist :
Changelist :
Completed Sprint-3, Implement and Rewrite Tests Coursework