Birmingham | ITP Jan-2026 | Arunkumar Akilan | Sprint 3 | Implement and Rewrite Tests#1164
Conversation
cjyuan
left a comment
There was a problem hiding this comment.
Indentation is off and some of the code is not consistently formatted.
Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode,
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.
If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:
- Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
- Edit
settings.jsonand set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
Thanks for the feedback. I have now installed the Prettier extension in VS Code, enabled format on save and paste, and formatted the files. The indentation and formatting should now be consistent. Please let me know if anything else needs improvement. |
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
619ac8a to
c6fe4be
Compare
c6fe4be to
e18a262
Compare
| if (denominator === 0) { | ||
| return false; | ||
| } | ||
| return Math.abs(numerator) < Math.abs(denominator); |
There was a problem hiding this comment.
The indentation is off. Looks like you may not have successfully assigned "prettier" as your default JS formatter.
Learners, PR Template
Self checklist
Changelist
Implemented the required functions and updated the test files for the Sprint 3 Implement and Rewrite Tests exercises.
Completed the following:
getAngleTypeisProperFractiongetCardValueQuestions
No questions at this time.