Skip to content

Birmingham | ITP Jan-2026 | Arunkumar Akilan | Sprint 3 | Practice TDD#1161

Open
arunkumarakilan wants to merge 7 commits intoCodeYourFuture:mainfrom
arunkumarakilan:coursework/sprint-3-practice-tdd-new
Open

Birmingham | ITP Jan-2026 | Arunkumar Akilan | Sprint 3 | Practice TDD#1161
arunkumarakilan wants to merge 7 commits intoCodeYourFuture:mainfrom
arunkumarakilan:coursework/sprint-3-practice-tdd-new

Conversation

@arunkumarakilan
Copy link

@arunkumarakilan arunkumarakilan commented Mar 4, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented the functions for the Sprint 3 Practice TDD exercises.

Completed:

  • countChar
  • getOrdinalNumber
  • repeatStr

All tests pass successfully.

@arunkumarakilan arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026
@arunkumarakilan arunkumarakilan mentioned this pull request Mar 7, 2026
Open
cjyuan
cjyuan reviewed Mar 14, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Function implementation is correct.

  • Code format is a bit inconsistent.

  • Tests are quite comprehensive. However, the test descriptions could be made clearer.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 14, 2026
@arunkumarakilan arunkumarakilan added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 16, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 16, 2026

Changes look good. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arunkumarakilan @cjyuan